Merged
Conversation
Contributor
Author
|
I'm unclear why this failed. Any help would be appreciated. |
The behavior of the html beautifier changed to preserve leading whitespace and use it to determing base indent level. Trimming the leading whitespace makes beautifier behave the same as it was previously.
When indent_char is tab, indent_size is now used to calculate the number of columns an indent uses. This matters for wrap attributes indenting and for line length wrapping calculations.
Previously, if a range started and ended inside an element it would not be formatted. However, if it started inside an element but ended outside it would format. With this change as long as the range starts outside on element it will format. This is safe as the beautifier formats incomplete html just fine up to where it ends.
Improved support for php, handlebars, and other template languages. This support is far from complete but generally works for inline use cases where formatting inside the templating only needs preserving.
bitwiseman
force-pushed
the
update-1.9.0-beta1
branch
from
ceb15f4 to
83e6a8e
Compare
Collaborator
|
Thanks a lot @bitwiseman, I'll merge on Monday for the January Build |
Contributor
Author
|
@aeschli |
Contributor
Author
|
@aeschli Here's some highlights you can use for the release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.9.0 will be out soon.
It addresses a number of line wrapping issues (such as beautifier/js-beautify#1324). If we can update this plugin to 1.9.0-beta1, it will give the next release a lot of good testing.