Fix/40149: add data-* attributes autocomplete#17
Merged
aeschli merged 6 commits intomicrosoft:masterfrom Dec 20, 2017
Merged
Conversation
added 4 commits
December 15, 2017 22:42
Add two test cases
Extract code to function.
|
|
pfongkye
commented
Dec 19, 2017
| const dataAttr = 'data-'; | ||
| let dataAttributes: string[] = []; | ||
|
|
||
| function addNodeDataAttributes(node: Node) { |
Author
There was a problem hiding this comment.
I could try a non-recursive approach
aeschli
requested changes
Dec 19, 2017
src/services/htmlCompletion.ts
Outdated
| let dataAttributes: string[] = []; | ||
|
|
||
| function addNodeDataAttributes(node: Node) { | ||
| node.attributeNames.filter(attr => attr.substr(0, dataAttr.length) === dataAttr).forEach(attr => { |
Collaborator
There was a problem hiding this comment.
I'd suggest doing a single forEach loop (no filter)
use startsWith from ../utils/strings for the check.
src/services/htmlCompletion.ts
Outdated
|
|
||
| function addNodeDataAttributes(node: Node) { | ||
| node.attributeNames.filter(attr => attr.substr(0, dataAttr.length) === dataAttr).forEach(attr => { | ||
| if (dataAttributes.indexOf(attr) === -1) { |
Collaborator
There was a problem hiding this comment.
Use a object or Map to check for extistece
if (!dataAttributes['attr']) {
dataAttributes['attr'] = true;
...
Author
There was a problem hiding this comment.
ok I'll make the modification ASAP
Author
|
@aeschli requested modifications applied. |
Collaborator
|
@pfongkye Thanks, great PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is referenced here: microsoft/vscode#40149