Display in data inspector ULEB128 and SLEB128 #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show in data inspector missing large integer formats as ULEB128 and SLEB128 (Little Endian Base 128)
In case of malformed LEB128
connor4312
reviewed
Feb 18, 2024
connor4312
previously approved these changes
Feb 19, 2024
Add bounds check for the case where the input buffer is too short and does not contain the expected final byte. Handle this case gracefully and remove the try/catch.
connor4312
approved these changes
Feb 20, 2024
Tyriar
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show in data inspector missing large integer formats as ULEB128 and SLEB128 (Little Endian Base 128)
Closes #485