fix: Duplicates Tasks for multiple level projects #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
requested review from
Eskibear,
jdneo and
testforstephen
as code owners
Collaborator
Author
|
steps to verify:
reference: stable marketplace version(3.12.0): |
19 tasks
Member
|
verified with |
CsCherrYY
added a commit
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1194
The difference between the two methods:
Project.getSubprojects()returns all sub projectsProject.getChildprojects()returns direct children (sub projects)See https://docs.gradle.org/current/dsl/org.gradle.api.Project.html for the details. Since we use recursive calls to get the hierarchical projects, here we should use
Project.getChildprojects()to avoid duplicating.