feat: Support workspaces without wrapper #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
changed the title
Eskibear
reviewed
Oct 21, 2021
| ): Promise<boolean> { | ||
| if ( | ||
| ( | ||
| await vscode.workspace.findFiles( |
Eskibear
reviewed
Oct 21, 2021
| this.setRootProjectFolder(rootProject); | ||
| } | ||
| } | ||
| gradleProjectFoldersOutsideRoot |
Member
There was a problem hiding this comment.
for projects outside root, we still add them in?
Collaborator
Author
There was a problem hiding this comment.
This comes from the setting gradle.nestedProjects. When it's set to an array of directories, we will support projects in the list even if they are outside root. The default value is false, this variable will be empty then. Ref: #339
Eskibear
approved these changes
Oct 22, 2021
This was referenced Oct 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1004
since local Gradle installation has been supported, the requirement of wrapper can be removed.