Skip to content

Add notebook group to newFile contribution#120

Merged
jrieken merged 1 commit intomainfrom
rzhao271/notebook-group
Apr 5, 2022
Merged

Add notebook group to newFile contribution#120
jrieken merged 1 commit intomainfrom
rzhao271/notebook-group

Conversation

@rzhao271
Copy link
Contributor

Based on microsoft/vscode#146022.

This PR adds a group key to the newFile contribution so that the notebook can show up in the same category as other notebook extensions.

@rzhao271 rzhao271 requested review from jrieken and roblourens April 4, 2022 23:14
@rzhao271 rzhao271 self-assigned this Apr 4, 2022
@rzhao271 rzhao271 added this to the April 2022 milestone Apr 4, 2022
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Lgtm

@jrieken jrieken merged commit 0228d21 into main Apr 5, 2022
@jrieken jrieken deleted the rzhao271/notebook-group branch April 5, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants