This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Allow testing against latest Insiders app#89
Merged
bpasero merged 1 commit intomicrosoft:masterfrom Dec 5, 2017
Merged
Conversation
This change allows setting CODE_VERSION to 'insiders' which will trigger download of an Insiders build and using that for test execution. Fixes microsoft#88. Signed-off-by: Gunnar Wagenknecht <[email protected]>
Contributor
Author
|
@bpasero Here is a PR. I hijacked the For simplicity reason I do expect an external entity to clean-up previous Also, let me know if there is any readme or changelog that needs to be updated. |
guw
commented
Dec 4, 2017
|
|
||
| getTag(function (tag) { | ||
| return clb(['https://vscode-update.azurewebsites.net', tag, downloadPlatform, 'stable'].join('/')); | ||
| return clb(['https://vscode-update.azurewebsites.net', tag, downloadPlatform, (isInsiders ? 'insider' : 'stable')].join('/')); |
Contributor
Author
There was a problem hiding this comment.
If you aren't a fan for the ? operator I can move it into a method and re-use that below as well.
guw
commented
Dec 4, 2017
| if(isInsiders) { | ||
| windowsExecutable = path.join(testRunFolderAbsolute, 'Code - Insiders'); | ||
| darwinExecutable = path.join(testRunFolderAbsolute, 'Visual Studio Code - Insiders.app', 'Contents', 'MacOS', 'Electron'); | ||
| linuxExecutable = path.join(testRunFolderAbsolute, 'VSCode-linux-x64', 'code-insiders'); |
Contributor
Author
There was a problem hiding this comment.
I intentionally dropped the special version handling for older versions for the Insiders stream.
Member
|
@guw great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows setting CODE_VERSION to 'insiders' which will trigger
download of an Insiders build and using that for test execution.
Fixes #88.