This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Update all dependencies.#79
Merged
bpasero merged 2 commits intomicrosoft:masterfrom Oct 13, 2017
JimiC:update_depends
Merged
Conversation
Member
|
@JimiC we cannot bump the types for node though, they have to stay in sync with the node.js runtime we ship with in VS Code which today is
|
Contributor
Author
|
@bpasero Valid point. I had a look on v7 and v8 definitions of |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I checked out what the majority of the dependencies updates was about and it turned out to be dependencies updates, bug fixes, and new features.
I tested this with the
editorconfig-vscodeextension, in which I contribute by fixing the test cases from time to time, by forcing thevscodepackage to use the updated dependencies and all looked good.So I'm confident that there are no breaking changes, but in case I'm horribly wrong, we'll find out pretty quickly.