Fix triage-needed issues across multiple samples#1288
Open
fhwvtqdc2q-svg wants to merge 2 commits into
Open
Conversation
Replace deprecated typescript.tsc.autoDetect with js/ts.tsc.autoDetect (microsoft#1285), add background problemMatcher to helloworld-sample for reliable F5 builds (microsoft#1159), improve catTools tool calling for Claude and file-search prompts (microsoft#1282), and add panel/secondarySidebar viewsContainers to webview-view-sample (microsoft#1261). Document language-configuration.json schema validation behavior (microsoft#1254). Co-authored-by: Cursor <[email protected]>
…ules - Extract lmTools.ts helper: toLanguageModelChatTools() guarantees every tool carries a non-undefined inputSchema object, fixing Claude model rejections (Fixes microsoft#1282 more completely) - Use getToolsForRequest() in both chatUtilsSample.ts and toolParticipant.ts so the filtering logic lives in one place - Correct swapped increaseIndentPattern / decreaseIndentPattern in language-configuration-sample (microsoft#1254): increase now matches lines ending with an unclosed opening bracket; decrease matches closing brackets Co-authored-by: Cursor <[email protected]>
fhwvtqdc2q-svg
commented
Jun 19, 2026
fhwvtqdc2q-svg
left a comment
fhwvtqdc2q-svg
left a comment
Contributor
Author
There was a problem hiding this comment.
Done my problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript.tsc.autoDetectwithjs/ts.tsc.autoDetectacross 31 samples (Fixes Update deprecated setting typescript.tsc.autoDetect #1285)problemMatchertohelloworld-sampleso F5 waits for the initial TypeScript watch build (Fixes Hello world - Compilation didn't run at the launch of the extension (press F5) #1159)@catToolstool calling for Claude and file-search prompts inchat-sample(Fixes chat-sample does not work with Claude model #1282)viewsContainersexamples for activity bar, panel, and secondary sidebar inwebview-view-sample(Fixes Add examples for viewsContainers #1261)language-configuration.jsonschema validation behavior inlanguage-configuration-sample(Related to VSCode not validating sample #1254)Test plan
npm run compileinchat-samplenpm run compileinwebview-view-samplehelloworld-sampleon Windows and verifyout/is created before the extension host starts@catTools search the package.json filewith a Claude model and verifyfindFilesis invoked