All CLA requirements met.

Hey @dbaeumer, is there anything I can do to help expedite getting this PR reviewed / merged? 🙂

@dbaeumer Could you review my changes when you get a chance?

I'm really eager to get these changes merged & published, as the only way I can use VSCode at work right now is via the [Extension Development Host] VSCode window spawned by the "Launch Client" launch configuration of this plugin. It works, but it feels silly! 😅

@dbaeumer Could you take a look? I believe I've made all of the requested changes.

@dbaeumer Are we good to merge this?

@dbaeumer @Hirse I noticed the repo ownership changed since I opened this PR… is there anything I can do to get this merged and released? As far as I can tell, it's good to go.

@dbaeumer Sorry to keep nagging, but it's been over a month since I made the changes you requested! Did I miss anything? I'd really like to get this PR merged! 🙏🙏

I've merged the latest upstream changes into the PR branch, and verified that everything is working as expected.

I'd really appreciate some feedback regarding this PR!

By the way, the change requested is on a line that's unaffected by the actual change, which might be why GitHub isn't showing that PR comment as "outdated".

I merged it in but changed env back to let env: { [key: string]: string | number | boolean }. Was there a deeper reason why you remove number and boolean and added undefined. We should not allow undefined as a value in env when setting.

Thanks!! It's been awhile, but I think I made that change because I saw a type error when running the extension in debug mode? I've gotten to know TypeScript a lot better since I wrote that though, I agree that including undefined was a mistake. Although NodeJs doesn't allow process.env to contain values other than string - such values are just coerced to string though, so it's not that big of a deal.

Thanks again!

@mattlubner would you mind provide a default value for NODE_ENV configuration ?
I have met an issue with [email protected] and ejected
debug info:

2022-02-02T09:24:47.689Z eslint:cli-engine Lint /Users/yzg/workspace/test/react-rxjs/src/index.js
2022-02-02T09:24:47.689Z eslint:linter Linting code for /Users/yzg/workspace/test/react-rxjs/src/index.js (pass 1)
2022-02-02T09:24:47.689Z eslint:linter Verify
2022-02-02T09:24:47.689Z eslint:linter With ConfigArray: /Users/yzg/workspace/test/react-rxjs/src/index.js
2022-02-02T09:24:47.693Z eslint:linter Parsing error: [BABEL] /Users/yzg/workspace/test/react-rxjs/src/index.js: Using `babel-preset-react-app` requires that you specify `NODE_ENV` or `BABEL_ENV` environment variables. Valid values are "development", "test", and "production". Instead, received: undefined. (While processing: "/Users/yzg/workspace/test/react-rxjs/node_modules/babel-preset-react-app/index.js")
Error: [BABEL] /Users/yzg/workspace/test/react-rxjs/src/index.js: Using `babel-preset-react-app` requires that you specify `NODE_ENV` or `BABEL_ENV` environment variables. Valid values are "development", "test", and "production". Instead, received: undefined. (While processing: "/Users/yzg/workspace/test/react-rxjs/node_modules/babel-preset-react-app/index.js")
    at module.exports (/Users/yzg/workspace/test/react-rxjs/node_modules/babel-preset-react-app/create.js:58:11)
    at module.exports (/Users/yzg/workspace/test/react-rxjs/node_modules/babel-preset-react-app/index.js:19:10)
    at sync (/Users/yzg/workspace/test/react-rxjs/node_modules/@babel/core/lib/gensync-utils/async.js:38:25)
    at sync (/Users/yzg/workspace/test/react-rxjs/node_modules/gensync/index.js:182:19)
    at /Users/yzg/workspace/test/react-rxjs/node_modules/gensync/index.js:210:24
    at Generator.next (<anonymous>)
    at /Users/yzg/workspace/test/react-rxjs/node_modules/@babel/core/lib/config/full.js:217:21
    at Generator.next (<anonymous>)
    at Function.<anonymous> (/Users/yzg/workspace/test/react-rxjs/node_modules/@babel/core/lib/gensync-utils/async.js:25:3)
    at Generator.next (<anonymous>)

https://github.com/facebook/create-react-app/blob/main/packages/babel-preset-react-app/create.js#L57
if there is no NODE_ENV setted, it will throw an error, I think set to NODE_ENV=development as default might fix this.