Issue 529, Added support for pnpm#572
Merged
dbaeumer merged 3 commits intomicrosoft:masterfrom Dec 17, 2018
Merged
Conversation
|
|
dbaeumer
reviewed
Nov 21, 2018
| npm: { | ||
| cache: undefined, | ||
| get(): string { | ||
| const npmPath = execSync('npm root -g').toString().trim(); |
Member
There was a problem hiding this comment.
Can we keep using Files.resolveGlobalNodePath here to make sure we are not breaking anything.
dbaeumer
reviewed
Nov 21, 2018
dbaeumer
requested changes
Nov 21, 2018
Member
dbaeumer
left a comment
dbaeumer
left a comment
There was a problem hiding this comment.
The PR looks good to me except the two comments I have.
| const packageManager = Workspace.getConfiguration('eslint', uri).get('packageManager', 'npm'); | ||
| const localInstall = { | ||
| npm: 'npm install eslint', | ||
| pnpm: 'pnpm install pnpm', |
There was a problem hiding this comment.
Shouldn't this say pnpm install eslint?
There was a problem hiding this comment.
@dbaeumer this PR has been merged but this change wasn't added
Member
There was a problem hiding this comment.
What exactly are you referring to?
This was referenced Jan 8, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.