Merged
Conversation
Member
|
Can you please update the readme as well to outline that we have that support now. |
Contributor
Author
|
Sorry for the delay. I added |
dbaeumer
approved these changes
Feb 5, 2025
alexdima
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for automatic eslint probing for the Civet language according to the existence of the plugin eslint-plugin-civet. This avoids having to force linting via
eslint.validate(which also works but is more tedious for the user).Here's an example repo directory to test on. Here's a screenshot of it working with this PR (lots of intentional errors):
Based on #1795 (analogous PR for Astro)