Skip to content

Add languages guide for Ruby#6152

Merged
gregvanl merged 1 commit into
microsoft:mainfrom
Shopify:add-ruby-guide
Mar 23, 2023
Merged

Add languages guide for Ruby#6152
gregvanl merged 1 commit into
microsoft:mainfrom
Shopify:add-ruby-guide

Conversation

@vinistock
Copy link
Copy Markdown
Contributor

@vinistock vinistock commented Mar 21, 2023

Add a guide for the Ruby language in VS Code. The entry explains how to set up and use the Ruby LSP and is very similar to the Rust docs.

cc @isidorn

@gregvanl
Copy link
Copy Markdown

gregvanl commented Mar 23, 2023

Hi @vinistock Thank you for submitting a PR, I haven't done a full review but I noticed that you are committing the images as binary files.
The vscode-docs repo uses Git LFS (Large File System) to avoid committing large image and video files to the repo. You can learn how to install and enable Git LFS in https://github.com/microsoft/vscode-docs/blob/main/README.md#cloning.

Can you either update this PR or create a new PR with Git LFS enabled in your local forked repo? Thanks

@vinistock
Copy link
Copy Markdown
Contributor Author

vinistock commented Mar 23, 2023

Followed the steps to setup LFS for my local fork and made the commit again.

gregvanl
gregvanl approved these changes Mar 23, 2023
View reviewed changes
Copy link
Copy Markdown

@gregvanl gregvanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Thanks!

I'll do a follow up PR for some small edits and formatting and to fill in the missing metadata.

@gregvanl gregvanl merged commit 38ec2ae into microsoft:main Mar 23, 2023
@vinistock
Copy link
Copy Markdown
Contributor Author

vinistock commented Mar 24, 2023

Thank you! We weren't sure how to fill the metadata indeed.

@vinistock vinistock deleted the add-ruby-guide branch March 24, 2023 13:39
@gregvanl
Copy link
Copy Markdown

gregvanl commented Mar 24, 2023 •
edited
Loading

Here's the follow up PR that we just merged #6159
A little hard to see actual text changes because I removed the in-paragraph link breaks, per our convention.
I moved the topic up in the TOC between R and Rust, `cause why not?
We should be able to publish today. Thank you again!

@vinistock
Copy link
Copy Markdown
Contributor Author

vinistock commented Mar 24, 2023

Amazing. Thanks again!

@gregvanl
Copy link
Copy Markdown

gregvanl commented Mar 24, 2023

Apologies, it looks like the new topic won't go live until Monday (a few website updates in progress)

@gregvanl
Copy link
Copy Markdown

gregvanl commented Mar 27, 2023

Published at https://code.visualstudio.com/docs/languages/ruby
We'll give this new topic a mention in the next 1.77 release notes in the "Documentation" section

@gregvanl
Copy link
Copy Markdown

gregvanl commented Mar 30, 2023

@vinistock Readers are happy

image

@vinistock
Copy link
Copy Markdown
Contributor Author

vinistock commented Mar 31, 2023

Amazing news! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gregvanl gregvanl gregvanl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gregvanl gregvanl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vinistock @gregvanl