Skip to content

Add selectedText to variable substitution section#1317

Merged
gregvanl merged 1 commit intomicrosoft:vnextfrom
yitongding:addSelectedText
Dec 28, 2017
Merged

Add selectedText to variable substitution section#1317
gregvanl merged 1 commit intomicrosoft:vnextfrom
yitongding:addSelectedText

Conversation

@yitongding
Copy link

@isidorn
Copy link
Contributor

isidorn commented Dec 22, 2017

This looks good to me.
Assigning to @gregvanl for the final review

@gregvanl gregvanl added this to the January 2018 milestone Dec 27, 2017
@gregvanl
Copy link

@yitongding Can you move this PR to our vscode-docs vnext branch since it documents a change that will be coming in the next release? It will then go to vscode-docs master along with the rest of the 1.20 documentation updates. Thanks.

@yitongding yitongding changed the base branch from master to vnext December 28, 2017 21:50
@yitongding
Copy link
Author

@gregvanl Thanks for reminding. Just did.

@gregvanl gregvanl merged commit 328f075 into microsoft:vnext Dec 28, 2017
@gregvanl
Copy link

@yitongding Great, thanks.

@gregvanl gregvanl removed this from the January 2018 milestone Feb 2, 2018
@yitongding yitongding deleted the addSelectedText branch February 9, 2018 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants