[scss] Path resolver to include partial files support #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
aeschli
approved these changes
Nov 27, 2023
justschen
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When importing partials (e.g "_mixins.scss"), it's unnecessary to explicitly include the underscore (
_). Sass inherently understands and imports files with or without the underscore. Therefore,@import "mixins.scss"is a valid way to import the partial.Why has this change been made?
Navigating to a partial file using
Command + ClickorControl + Clickwithout specifying the underscore was causing the language server to be unable to find the path.Changes
toPathVariationsfunction to consider partial files when the underscore has been omitted.Before
After