Skip to content

Added @error support for sass#24

Merged
aeschli merged 2 commits intomicrosoft:masterfrom
Kiricon:sass_error_kiricon
Mar 31, 2017
Merged

Added @error support for sass#24
aeschli merged 2 commits intomicrosoft:masterfrom
Kiricon:sass_error_kiricon

Conversation

@Kiricon
Copy link
Contributor

@Kiricon Kiricon commented Mar 25, 2017

Added support for @error linting for sasss.
Related to Microsft/vscode#22735

Kiricon added 2 commits March 24, 2017 21:19
Added support for `@error` linting for sass as requested in a vscode issue (#22735)
@Kiricon Kiricon closed this Mar 25, 2017
@Kiricon Kiricon deleted the sass_error_kiricon branch March 25, 2017 03:31
@Kiricon Kiricon restored the sass_error_kiricon branch March 25, 2017 03:53
@Kiricon Kiricon reopened this Mar 25, 2017
@Kiricon
Copy link
Contributor Author

Kiricon commented Mar 25, 2017

The build seems to be failing due to the dependency vscode-languageserver-types containing the typing for WorkspaceEdit having been changed recently, making the version index no longer compatible.

As I'm currently unaware of what the proper fix is I'll simply open an issue for the time being.
Issue #25

@aeschli aeschli merged commit 99ff253 into microsoft:master Mar 31, 2017
@aeschli
Copy link
Collaborator

aeschli commented Mar 31, 2017

Thanks, great PR. It will go in the April release.

@aeschli aeschli added this to the April 2017 milestone Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants