Wrap URI.parse() call in try ... catch#180
Merged
aeschli merged 1 commit intomicrosoft:masterfrom Oct 7, 2019
sryze:uri-parse-error
Merged
Wrap URI.parse() call in try ... catch#180aeschli merged 1 commit intomicrosoft:masterfrom sryze:uri-parse-error
aeschli merged 1 commit intomicrosoft:masterfrom
sryze:uri-parse-error
Conversation
Collaborator
|
Looks good, thanks @sryze ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
URI.parse()encounters an invalid URL it can throw aURIError, but the error is never caught and it pops up in the user's face (issue #173). So this patch simply puts the parse call in a try ... catch statement.I don't know if the URI library is supposed to throw an error in this case, it may be an issue with vscode-uri.
Steps to reproduce the error:
If you are wondering why I would be using an invalid URL - it's not really invalid, the CSS file produced by the SCSS compiler in my project is included inline into a JSP page, and the
url()actually contains a JSP echo tag inside (<%=some expression%>). This used to work in VS Code 1.36 and earlier, but started to throw an error in newer releases.