Enable strict compiler setting#167
Merged
aeschli merged 28 commits intomicrosoft:masterfrom Aug 21, 2019
Merged
Conversation
|
|
ghaith6558
approved these changes
Jul 31, 2019
Collaborator
|
@brettjurgens Fantastic effort, thanks a lot!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the codebase to work with the strict compiler setting. I did my best to limit the code changes (other than the types) and tried to avoid non-null assertions (some were unavoidable and I was less concerned in the tests).
Due to the nature of the PR, it came out relatively big - I'm happy to break it up in whatever way would be easiest to review.
Thanks!
fixes #145