Improve scss partial uri building#159
Merged
octref merged 1 commit intomicrosoft:masterfrom Jul 4, 2019
BPScott:improve-scss-partials
Merged
Improve scss partial uri building#159octref merged 1 commit intomicrosoft:masterfrom BPScott:improve-scss-partials
octref merged 1 commit intomicrosoft:masterfrom
BPScott:improve-scss-partials
Conversation
- Identifies filenames that contain non-alphanumeric characters, 'foo-baz' becomes '_foo-baz.scss', - Identifies multiple extensions, 'foo.bar' becomes '_foo.bar.scss', while 'foo.bar.scss' still becomes '_foo.bar.scss' - Identifies if a filename is already prefixed with an _, '_foo' becomes '_foo.scss' and '_foo.scss' remains '_foo.scss'
|
|
This was referenced Jul 1, 2019
Contributor
|
Thanks, I'll take the test case but I'll rewrite the code with a dynamic resolver. As I have learned from the Cloudflare news, I'll drop the regex. Especially since this operation is one running on each keystroke. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the regex for checking filenames uses
\wwhich only checks for alphanumeric characters and underscore (_). This leads to@import './foobar'resolving to_foobar.scsswhile@import './foo-barresolves tofoo-bar, which is confusing.This PR makes the prefixing the underscore behaviour more consistent:
'foo-baz' becomes '_foo-baz.scss' and 'foo.bar' becomes '_foo.bar.scss'
'_foo.scss' and '_foo.scss' remains '_foo.scss'
Tangentially related: microsoft/vscode#58204 is an issue that points out that the resolution of scss files isn't trivial because
import './foo'could refer to eitherfoo.scssor_foo.scssand we need filesystem access to check which of those files exist. So we're still assuming that people should be prefixing their partial's filenames with underscores, but at least this makes that assumption a little more consistent.