Merged
Conversation
KamasamaK
reviewed
Jan 2, 2019
KamasamaK
reviewed
Jan 2, 2019
| return low; | ||
| } | ||
|
|
||
| export function includes<T>(array: T[], item: T): boolean { |
Contributor
There was a problem hiding this comment.
Alternatively, add es2016.array.include to compilerOptions.lib in the tsconfig.
Contributor
Author
There was a problem hiding this comment.
I can't find any statement about engine requirement (which version of node or browser it will run on), so I didn't modify lib config.
Collaborator
|
Thanks @KamasamaK, I reviewed the changes, but renamed the new file to be also used by future lint rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I always have
css.lint.boxModelon, but what I usually want to do is to override properties from other css files.The problem is, VS Code keeps warning me about this: Do not use width or height when using padding or border.
Does
padding: 0really counts as using?So instead of turn this feature off, I'd love to make it be aware of what I'm doing.