Don't warn for unknown properties inside an :export block#137
Merged
octref merged 1 commit intomicrosoft:masterfrom Jan 2, 2019
Merged
Don't warn for unknown properties inside an :export block#137octref merged 1 commit intomicrosoft:masterfrom
octref merged 1 commit intomicrosoft:masterfrom
Conversation
|
|
Contributor
Author
Contributor
|
Sorry both of us was on vacation. I'll review it in December. |
Contributor
Author
|
Thanks! Have nice holidays |
Contributor
|
LGTM. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently custom properties inside a CSS modules
:exportblock are reported as unknown. The properties inside:exportare not CSS properties - they are custom properties that are exported from the CSS/SCSS file to Javascript (e.g. variables).This PR adds a simple check to see if the selector is
:export, and skips the whole checking for unknown properties in that case.Please enable
Diff settings > hide whitespace changesfrom Github's UI when reviewing the PR.fixes #103