Rename specificity label and add a link to MDN#131
Merged
octref merged 2 commits intomicrosoft:masterfrom Oct 31, 2018
Merged
Conversation
|
|
octref
force-pushed
the
specificity-label
branch
from
afda73a to
c21a107
Compare
Contributor
|
I made some changes and pulled it in. Mainly because of the merge conflicts. Thanks again for the PR and don't forget to get your Microsoft shirt for Hacktoberfest! Today is the last day. https://open.microsoft.com/2018/09/30/join-hacktoberfest-2018-celebration-microsoft/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#62155
I renamed it "Selector specificity" instead of "CSS specificity" because the user would already know they are editing a CSS file and "Selector specificity" seemed like a better description.
I wasn't sure if the link should be included in the
localize()call or not. MDN has that page in other languages so maybe it should be localized to link to the appropriate language page? If this is not how it should be done I can change it.This is my first VS Code related contribution. I hope that it is helpful.