Fully support parsing Custom Property values.#11
Closed
rictic wants to merge 1 commit intomicrosoft:masterfrom
Closed
Fully support parsing Custom Property values.#11rictic wants to merge 1 commit intomicrosoft:masterfrom
rictic wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Fixes microsoft#7 This adds a new method for parsing css custom property values. It's written somewhat unusually due to the exceptionally broad allowed syntax for custom property values.
|
Thanks @rictic! |
aeschli
added a commit
that referenced
this pull request
Dec 3, 2016
Collaborator
|
@rictic I merged your pull request manually. Thanks a lot! Your implementation makes sense as it is what the spec describes. In the future we have to see how we can give better support to the definitions in the custom property set. I hope the spec gets more specific... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
This adds a new method for parsing css custom property values. It's written somewhat unusually due to the exceptionally broad allowed syntax for custom property values.