Skip to content

Additional localized strings for hover and auto-complete#5651

Merged
Colengms merged 6 commits intomasterfrom
dev/coleng/more_loc
Jun 17, 2020
Merged

Additional localized strings for hover and auto-complete#5651
Colengms merged 6 commits intomasterfrom
dev/coleng/more_loc

Conversation

@Colengms
Copy link
Copy Markdown
Contributor

Addresses: #5370
There is a corresponding PR on the native side.

  • Adds new stings that needed to be localized
  • Sends all native localized strings to native process during initialization
    • Note that strings requiring substition will include placeholders (i.e. "{0}").
  • Adds support for hints in nativeStrings.json

@bobbrow
Copy link
Copy Markdown
Member

bobbrow commented Jun 17, 2020

Does this mean we have to add support for {#} substitution in the native portion of the extension? Could we change it to %s or %d in the appropriate cases to save us a step?

Comment thread Extension/src/nativeStrings.json
Comment thread Extension/gulpfile.js Outdated
@Colengms Colengms merged commit 37dfc2d into master Jun 17, 2020
@Colengms Colengms deleted the dev/coleng/more_loc branch June 17, 2020 21:19
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants