Add prefer-const to eslint. Fix some other lint errors.#5634
Merged
sean-mcmanus merged 2 commits intomasterfrom Jun 15, 2020
Merged
Add prefer-const to eslint. Fix some other lint errors.#5634sean-mcmanus merged 2 commits intomasterfrom
sean-mcmanus merged 2 commits intomasterfrom
Conversation
Contributor
Author
|
I wasn't planning to check this in until the other existing PRs have gone in, to avoid breaking the PRs. |
michelleangela
approved these changes
Jun 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these changes were automatically made by running "eslint ** --fix". "const" variables in TypeScript are still mutable (e.g. arrays can be pushed to), they just can't be re-assigned. See https://eslint.org/docs/rules/prefer-const .