Skip to content

Fix task bugs.#5585

Merged
sean-mcmanus merged 2 commits intomasterfrom
seanmcm/fixCppTasks
Jun 1, 2020
Merged

Fix task bugs.#5585
sean-mcmanus merged 2 commits intomasterfrom
seanmcm/fixCppTasks

Conversation

@sean-mcmanus
Copy link
Copy Markdown
Contributor

Fixes microsoft/vscode-docs#3724, #5561, #3295, #4761 .

Problems are:

  1. The task source was incorrectly changed to "shell" (regression). Only the "type" registered task type needed to be shell: Please help me, I don't want to give up;About ADD tasks.json file vscode-docs#3724 .
  2. Using Configure Default Build Task would create a task with "shell: " or "C/C++: " in the name, while F5 would not. The adding of the source to the name is caused by VS. I had added a bug report at "Tasks: Configure Default Build Task" incorrectly adds "type: " to the tasks.json "label" property vscode#98838, but I just closed it since we can work around the issue via always adding the source to the name.
  3. Added the problemMatcher and group fields to the tasks created from F5 (and Build and Debug Active File): No problemMatcher added to auto-created build tasks #3295 .
  4. Change the cwd to be ${workspaceFolder} instead of "/usr/bin": questionable "cwd" value in default build task #4761 . The reason we did this originally was because Cygwin would fail, but that can be worked around via either adding Cygwin's bin folder the path or changing the cwd for those cases (but most users won't want cwd to be the path to the compiler, and Cygwin usage is low compared to other scenarios).

@bobbrow bobbrow added this to the 0.28.2 milestone Jun 1, 2020
@sean-mcmanus sean-mcmanus merged commit 5210e23 into master Jun 1, 2020
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixCppTasks branch June 1, 2020 20:40
@sean-mcmanus sean-mcmanus mentioned this pull request Jun 2, 2020
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please help me, I don't want to give up;About ADD tasks.json file

3 participants