Skip to content

Support Debug Welcome Panel#5503

Merged
WardenGnaw merged 2 commits intomasterfrom
dev/waan/debugWelcome
Jun 15, 2020
Merged

Support Debug Welcome Panel#5503
WardenGnaw merged 2 commits intomasterfrom
dev/waan/debugWelcome

Conversation

@WardenGnaw
Copy link
Copy Markdown
Member

@WardenGnaw WardenGnaw commented May 15, 2020

This PR enables the Debug Welcome Panel for c/cpp languages.

This allows us to add content to the Debug Welcome Screen (no .vscode tasks or launch). at the moment I am just adding the C/C++ documentation.

image

Clicking on “Run and Debug” gives the “Run and Debug Active File” experience.

image
image

Linked Issue: #4837

@WardenGnaw WardenGnaw requested a review from bobbrow May 15, 2020 18:31
@WardenGnaw WardenGnaw self-assigned this May 15, 2020
@WardenGnaw WardenGnaw requested a review from a team May 15, 2020 18:31
@WardenGnaw
Copy link
Copy Markdown
Member Author

@jureid

@jureid
Copy link
Copy Markdown
Contributor

jureid commented May 19, 2020

@WardenGnaw which document does this link to?

@WardenGnaw
Copy link
Copy Markdown
Member Author

@jureid
Copy link
Copy Markdown
Contributor

jureid commented May 20, 2020

Got it. I think it might be more helpful to link to this debug config doc, since at this point the customer is probably trying to learn about launch.json as they need to create one.

Then we can change the button text to "Learn more about launch.json" or "Learn more about configuring C/C++ debugging".

Also, is the primary action we want customers to take to click on "Run and debug"? If so, maybe the link to documentation should just be a string with a hyperlink rather than a button:

"To learn more about launch.json, see Configuring C/C++ debugging."

Let me know what you think.

This PR enables the Debug Welcome Panel for c/cpp languages.
@WardenGnaw WardenGnaw force-pushed the dev/waan/debugWelcome branch from 4664569 to e062dfa Compare June 12, 2020 23:53
@WardenGnaw WardenGnaw marked this pull request as ready for review June 12, 2020 23:53
@WardenGnaw WardenGnaw merged commit 0dea2e4 into master Jun 15, 2020
@WardenGnaw WardenGnaw deleted the dev/waan/debugWelcome branch June 15, 2020 20:46
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants