Skip to content

Conversation

@elahehrashedi
Copy link
Contributor

Custom config provider extension users should not see the message "Please update your includePath.
bug fix: #3971

@elahehrashedi elahehrashedi requested review from a team and sean-mcmanus May 4, 2020 07:32
@elahehrashedi
Copy link
Contributor Author

@sean-mcmanus do you think we should add more information to the message, for example:
"#include errors detected based on information provided by configurationProvider. IntelliSense features for this translation unit ({0}) will be provided by the Tag Parser."

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented May 6, 2020

@sean-mcmanus do you think we should add more information to the message, for example:
"#include errors detected based on information provided by configurationProvider. IntelliSense features for this translation unit ({0}) will be provided by the Tag Parser."

Yeah, that sounds good, but change it to "...provided by the configurationProvider setting." in case users don't know that "configurationProvider" is a setting, since it can get auto-set it from a popup dialog.

@elahehrashedi elahehrashedi merged commit 5fe62db into master May 7, 2020
@elahehrashedi elahehrashedi deleted the elrashed/3971 branch May 7, 2020 22:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom config provider extension users should not see the message "Please update your includePath."

4 participants