Fix windows remote attach experience#3757
Merged
WardenGnaw merged 5 commits intomasterfrom Jun 12, 2019
Merged
Conversation
Attach to process is not working on Windows OS due to the single quote then double inner quote. However, this is required for linux because if you do not, it will evaluate the variables within the double quotes.
Contributor
|
Was a GitHub issue filed on this? |
sean-mcmanus
approved these changes
Jun 12, 2019
Member
Author
Not that I know of. I ran across this while doing other work. |
Contributor
|
@WardenGnaw you should create an issue and link it. people who run into problems search issues and this would help explain the problem while being findable on the issues search. |
Contributor
|
also please add your test matrix to this in case we run into a problem in the future. |
pieandcakes
approved these changes
Jun 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows remote attach to process picker was not working due to double quotes then single quotes on the host machine.
This PR fixes this issue and selects the correct quotes depending on the correct host machine. Fixes #3758