Use .NET SDK to search for NuGet packages, emit events, add tests for all package types #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
force-pushed
the
jver/nuget-mcp-server-json
branch
from
156b75f to
36f9067
Compare
joelverhagen
force-pushed
the
jver/nuget-mcp-server-json
branch
from
49d975d to
a229016
Compare
Contributor
Author
|
@connor4312 - could you review this? |
joelverhagen
commented
Aug 12, 2025
joelverhagen
commented
Aug 12, 2025
connor4312
reviewed
Aug 12, 2025
…' into jver/nuget-mcp-server-json # Conflicts: # src/extension/mcp/vscode-node/commands.ts # src/extension/mcp/vscode-node/nuget.ts
connor4312
approved these changes
Aug 13, 2025
aeschli
approved these changes
Aug 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on microsoft/vscode#257679 and microsoft/vscode#259901 (switch to .NET SDK to allow for custom package sources in the future -- still hard coded to nuget.org right now).
Depends on microsoft/vscode#259634 (NuGet can return a server.json instead of a vscode MCP.json)
Summary of changes:
setup:dotnetand make it work on Windows, this is for local useactions/setup-dotnetfor setting up .NET on GitHub Actions, since this is the "blessed" way to do it, like we are for Python and node.js.PublicNonPersonalDatais used in the repo, but I think it's the best fit for package names based on my investigation of the vscode repo (these are similar to extension names I think)nuget.tsfile, but it could be moved to a shared place, or perhaps there's an existing implementation I should use.Verified with:
@azure/mcp(old flow, no server.json)mcp-server-fetch(old flow, no server.json)mcp/node-code-sandbox(old flow, no server.json)NuGet.Mcp.Server(new flow),Knapcode.SampleMcpServer(new flow, this one has an input)Happy path (with server.json)
Video.webm
dotnetnot founddotnet-not-found.webm