Make capi client optional for completions in chat-lib#2369
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the ICAPIClientService parameter optional for inline completions in chat-lib, aligning it with the pattern already used by the NES (Next Edit Suggestions) provider. Previously, consumers had to provide their own implementation of ICAPIClientService; now they can rely on a default implementation using CAPIClientImpl.
Key changes:
- Made
capiClientServiceoptional in theIInlineCompletionsProviderOptionsinterface - Added default
CAPIClientImplimplementation whencapiClientServiceis not provided - Registered
IFetcherServicedependency required byCAPIClientImpl
jeffreyhunter77
force-pushed
the
jeffreyhunter77/default-completions-capi-client
branch
from
ac7319f to
a0f39d7
Compare
chrmarti
approved these changes
Dec 4, 2025
hediet
pushed a commit
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently creating an inline completions provider in chat-lib requires an implementation of
ICAPIClientService. This isn't actually needed. We can use a default implementation. This updates the inline completion provider to use the same service as NES by default.