Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates model hashes by migrating three hash values from VSC_MODEL_HASHES_B to VSC_MODEL_HASHES_A, effectively merging the model categories.
Key Changes
- Three hash strings (lines 24-26) moved from
VSC_MODEL_HASHES_Barray toVSC_MODEL_HASHES_Aarray VSC_MODEL_HASHES_Bredefined as an array containing only an empty string- Model identification logic remains unchanged
karthiknadig
requested changes
Nov 25, 2025
Comment on lines
29
to
31
| const VSC_MODEL_HASHES_B = [ | ||
|
|
||
| ]; |
Member
There was a problem hiding this comment.
Please leave a comment as to why this is empty.
Also I recommend adding it like this:
const VSC_MODEL_HASHES_B : string[] = [];
AbdelrahmanAbouelenin
force-pushed
the
ababouelenin/changing-vsc-hashes
branch
from
682be13 to
f935c00
Compare
karthiknadig
approved these changes
Nov 27, 2025
mjbvz
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving model B hashes to Model A.