Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds built-in support for the GitHub MCP (Model Context Protocol) Server to the extension. The feature is disabled by default and requires explicit opt-in via configuration. It supports both GitHub.com and GitHub Enterprise with configurable toolsets, readonly mode, and lockdown mode.
Key changes:
- New
GitHubMcpDefinitionProviderthat provides MCP server definitions based on configuration - Configuration settings for enabling GitHub MCP Server and controlling its behavior (toolsets, readonly, lockdown)
- Refactored
authProviderIdfunction to common authentication module for reuse - Enhanced test infrastructure to fire configuration change events
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/extension/githubMcp/common/githubMcpDefinitionProvider.ts | Core provider implementation that generates MCP server definitions with dynamic configuration |
| src/extension/githubMcp/vscode-node/githubMcp.contribution.ts | Contribution that registers the MCP definition provider when enabled |
| src/extension/githubMcp/test/node/githubMcpDefinitionProvider.spec.ts | Comprehensive unit tests covering provider behavior and configuration changes |
| src/platform/configuration/common/configurationService.ts | Adds four new configuration keys for GitHub MCP Server settings |
| src/platform/authentication/common/authentication.ts | Adds authProviderId helper function moved from session.ts |
| src/platform/authentication/vscode-node/session.ts | Removes authProviderId function (moved to common) |
| src/platform/authentication/vscode-node/authenticationService.ts | Updates import to use authProviderId from common module |
| src/platform/configuration/test/common/inMemoryConfigurationService.ts | Fires configuration change events when config is set |
| src/extension/extension/vscode-node/contributions.ts | Registers GitHubMcpContrib in contribution list |
| package.json | Adds MCP server definition provider contribution, configuration schema, and disables githubRepo tool when MCP is enabled |
| package.nls.json | Adds localized descriptions for new configuration settings |
Comment on lines
+118
to
+122
| return new GitHubMcpDefinitionProvider( | ||
| accessor.get(IConfigurationService), | ||
| accessor.get(IAuthenticationService), | ||
| accessor.get(ILogService) | ||
| ); |
There was a problem hiding this comment.
According to the coding guidelines (CodingGuidelineID: 1000002), tests should use IInstantiationService to create instances with mocks rather than manually passing dependencies. This ensures proper dependency injection. Change to: const instantiationService = accessor.get(IInstantiationService); return instantiationService.createInstance(GitHubMcpDefinitionProvider);
karthiknadig
previously approved these changes
Nov 20, 2025
DonJayamanne
previously approved these changes
Nov 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
TylerLeonhardt
dismissed stale reviews from DonJayamanne and karthiknadig
via
9ee3481
aeschli
approved these changes
Nov 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#254836
This allows the GitHub MCP Server to be readily available in-box.
To start, you must enable it with:
After that you should see it in your tool picker and if you have already signed in to Copilot Chat with the bigger token (to do codesearch, CCA, etc) no further auth should be required.
Oh, and if you're using GHE.com, that works too.
There's some configuration settings:
which align with https://github.com/github/github-mcp-server/blob/main/docs/remote-server.md#optional-headers
Oh, and if you enable this,
#githubRepois disabled since they are redundant.Next steps
Blocker
GitHub MCP is rolling out upscoping ...which is what we need to really support this. They've laid a foundation down with the
search_orgstool which will say you needread:orgsto query it if you give it a token that does not have that but:resource_metadatais currently wrong (small fix)So both those things, along with rolling it out to all tools, should be done before this could be enabled by default.