Modifications to allow direct-endpoint tests to use responses api #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugh it is used, it is not part of the interface. But defining it in the interface causes issues.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the "thinking" capability and "supported_endpoints" configuration to enable direct-endpoint tests to use the responses API. The changes allow model configurations to specify which endpoints they support and automatically enable the responses API when appropriate.
Key changes:
- Adds "thinking" capability support to model configurations
- Introduces "supported_endpoints" validation and configuration
- Automatically enables responses API configuration based on supported endpoints
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/simulationMain.ts | Adds validation for "thinking" capability and "supported_endpoints" array in model config parsing |
| src/platform/endpoint/test/node/test/openaiCompatibleEndpoint.spec.ts | Updates test model configuration to include new "thinking" capability and supported endpoints |
| src/platform/endpoint/test/node/openaiCompatibleEndpoint.ts | Implements responses API support with automatic configuration and custom request body handling |
Comments suppressed due to low confidence (1)
src/platform/endpoint/test/node/openaiCompatibleEndpoint.ts:1
- There is an extra closing brace on line 276. The code structure shows two closing braces in a row (lines 275 and 276) but only one opening brace for the if statement on line 262.
/*---------------------------------------------------------------------------------------------
lramos15
approved these changes
Sep 25, 2025
roblourens
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to allow direct-endpoint tests to use responses api