This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Fix node not hitting breakpoints in network paths#368
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Oct 16, 2018
Merged
Fix node not hitting breakpoints in network paths#368roblourens merged 1 commit intomicrosoft:masterfrom
roblourens merged 1 commit intomicrosoft:masterfrom
Conversation
Member
Why? We guessed at the path, that path was correct right? What's the real issue here? I don't see how breakOnLoad or network paths are involved. |
Contributor
Author
|
We guessed at the path, but we never set that breakpoint with that path (With break-on-load we set the break-on-load breakpoint instead of the real breakpoint, we need to set the real-breakpoint when parse the script). |
Member
|
Oh I see. The disconnect between BreakOnLoadHelper, and this check that makes assumptions about what the helper did, feels a little awkward. But I think this is ok. |
Member
|
Published -core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We couldn't hit a breakpoint in:
\myshare\myfolder\myfile.js