This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Allow child-class to customize the creation of IVariableContainer .#279
Merged
roblourens merged 2 commits intomicrosoft:masterfrom Feb 7, 2018
Merged
Allow child-class to customize the creation of IVariableContainer .#279roblourens merged 2 commits intomicrosoft:masterfrom
roblourens merged 2 commits intomicrosoft:masterfrom
Conversation
Allows the child debug adapter to override some variable handling logic.
roblourens
reviewed
Feb 7, 2018
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
This looks great. Is it ready to merge?
Contributor
Author
|
@roblourens Yes, it is ready to merge. We are actually waiting on it to merge the other PR in edge debug adapter. ( after we could bump up the chrome-core version) So please do a NPM release after the merge. Thanks Rob. |
Member
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows another Debug Adapter implementation to decide what will happen when an object is expanded and its properties are shown, and how to change value for each of the properties it owns.
We need this, because EDP uses a different way of changing an object's property. The current logic in setPropertyValue does not work for EDP.
After this override point is enabled. We are able to create and use another IVariableContainer like this: MSPropertyContainer. There we capture the needed metadata when an object is expanded. And use that metadata to change an object property value when
setValue()method is called.