This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Ignore some regex characters in sourcemap overrides pattern#261
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Dec 25, 2017
Merged
Conversation
|
|
msafi
changed the title
msafi
changed the title
roblourens
approved these changes
Dec 25, 2017
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
This looks great! I can probably reduce the number of "escape regex chars" util methods I have, and escaping whitespace doesn't seem necessary, but I will work on that. Thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to setup
vscode-chrome-debugfor our project.The source map URLs for our projects look like this:
So I tried the following
...but that didn't work because the code for the overrides treats the
+as part of a regex, which it's not.I've modified the code in
sourceMapUtils.tsto ignore some regex characters in the override URLs. Not sure if that's the right solution, but I hope that at least it illustrates the problem.(Sorry for mixing in formatting changes there!)