This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Fix site.js appearing in the call stack instead of site.ts#246
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Oct 5, 2017
Merged
Conversation
roblourens
approved these changes
Oct 5, 2017
Member
|
Good catch! |
Contributor
Author
|
@roblourens Is there any option for tslint that can catch these kind of things? |
Member
|
Not every async function should be awaited, it's tough to know just from looking at the code whether it's right or wrong. |
Contributor
Author
|
In C# you call .Forget() to signal that you are "not awaiting it" on purpose... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code wasn't awaiting, so part of the code to create the response run before resolving the source maps, and the other part after it so we ended up with part saying site.js and part saying site.ts