Support source mapping of stack traces in the Debug Console #6#190
Support source mapping of stack traces in the Debug Console #6#190roblourens merged 5 commits intomicrosoft:masterfrom nojvek:master
Conversation
|
Thanks, this looks great! Tests are always welcome. |
src/chrome/chromeDebugAdapter.ts
Outdated
| if (matches) { | ||
| const fnName = matches[1]; | ||
| const path = matches[2]; | ||
| const lineNum = parseInt(matches[3]); |
There was a problem hiding this comment.
TSLint failes due to missing radex param.
|
Just installed I press save and everything fixes itself. So awesome 😎 🎉 |
|
@roblourens I am trying to get the unit test for exceptions to work. Firing My test strategy is to fire a bunch of |
|
Looks like there's a typo in my mock event handling code - https://github.com/Microsoft/vscode-chrome-debug-core/blob/master/test/mocks/debugProtocolMocks.ts#L51 - should be |
|
@roblourens Thanks for the pointer. Making mocks work properly was a mission but I think I have it all working now. |
|
Awesome, thanks for the tests |

Will add some tests tomorrow. Still figuring out how tests work with sourcemap mocks.
Let me know if the code section looks good by you.
@auchenberg @roblourens