This repository was archived by the owner on Dec 6, 2022. It is now read-only.
Changing overlay text based on clients#599
Merged
roblourens merged 4 commits intomasterfrom Feb 14, 2018
Merged
Conversation
roblourens
suggested changes
Feb 13, 2018
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Thanks for the PR, I don't want to hardcode any more VS checks - could you make this a launch config param instead?
Member
|
And prefix the param with a |
Contributor
Author
|
@roblourens: Addressed. |
Member
|
Please don't add it to the package.json, that's what makes it show up for users in launch.json |
Contributor
Author
|
Done. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.