@luabud Can you look at the naming of this setting and description for this? This setting allows users to get a visible UI notification if there is a issue when formatting. We also need to decide on the default value for this setting.

I feel like this should be a enum, with values like never, on-error, and on-warn. on-error covers scenarios where formatting fails due to some error like syntax error, or out-of-date version etc. on-warn covers scenarios in the on-error plus cases where formatting is intentionally skipped.

I love the enum idea, and I don't see a problem with the setting name as is, but something more descriptive that this would show a notification could also work (e.g. black-formatter.promptMessages).

May be black-formatter.showNotification? so that "black-formatter.showNotification": "on-warn" makes more sense as to what it will do.

@luabud what do you think the default should be?

Love showNotification! As for the default value, my vote would be for "on-error" to avoid annoying those who feel strongly about notifications. But I don't have a strong opinion on this 😊

@luabud, Initially I agreed that default "on-error" would make sense, but after some thoughts I'd vote for "on-warn". The reason is simple: if user is annoyed by notifications, it's clear what's happening and how to fix it. On contrary, it's unclear what's happening when extension doesn't do what it supposed to do and doesn't emit any warnings either.

@Bobronium I don't we should rely on black to detect syntax errors. Jedi or Pylance can do a much better job at detecting these and adding an entry to the problems window that points to the exact line and column where the problem exists. This feels like it is adding additional responsibility to the black extension that I don't feel it should take on.

/cc @luabud what do you think?

I don't think this should be resource, this setting need not have workspace folder level of granularity. It can be machine where it can be handled in both local and remote scenarios.

I feel like these should be on-error, on-warn, always, and never. I also recommend adding enum descriptions.

An example, for enum descriptions:

                "python.languageServer": {
                    "default": "Default",
                    "description": "Defines type of the language server.",
                    "enum": [
                        "Default",
                        "Jedi",
                        "Pylance",
                        "None"
                    ],
                    "enumDescriptions": [
                        "Automatically select a language server: Pylance if installed and available, otherwise fallback to Jedi.",
                        "Use Jedi behind the Language Server Protocol (LSP) as a language server.",
                        "Use Pylance as a language server.",
                        "Disable language server capabilities."
                    ],
                    "scope": "window",
                    "type": "string"
                },

/cc @luabud Need your input on the enum values and the descriptions.

I believe this should be on-error, and when we do show notification there should be a way to add a button to the displayed message to trigger a setting change. This might be a limitation of the LSP, but if we can run a command for VS Code we could make this work. That is probably a separate thing.

/cc @luabud this is a prime candidate for experiment.