Skip to content

makes 'noUpdatesAvailable' info dialogs non-modal and less intrusive#98842

Closed
mathiask88 wants to merge 2 commits intomicrosoft:masterfrom
mathiask88:master
Closed

makes 'noUpdatesAvailable' info dialogs non-modal and less intrusive#98842
mathiask88 wants to merge 2 commits intomicrosoft:masterfrom
mathiask88:master

Conversation

@mathiask88
Copy link

@mathiask88 mathiask88 commented May 29, 2020

This PR fixes # - No associated issue

In my opinion the modal info dialog after checking for updates manually is disruptive. The notification service as used for any other notification around the update process is much nicer.

image
image

This is my personal opinion. If there is a specific reason for the modal dialog or you don't like the idea, feel free to close this PR.

@msftclas
Copy link

msftclas commented May 29, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno assigned sandy081 and unassigned joaomoreno Jun 2, 2020
@sandy081 sandy081 requested review from joaomoreno and sandy081 June 2, 2020 15:13
@sandy081 sandy081 added this to the June 2020 milestone Jun 2, 2020
@joaomoreno joaomoreno removed their assignment Jun 2, 2020
@kieferrm kieferrm modified the milestones: June 2020, July 2020 Jul 6, 2020
@mathiask88
Copy link
Author

mathiask88 commented Jul 18, 2020

Any update on this small changes?
@joaomoreno already removed the modal dialogue for the main update process in 7729e9c but for the extension update check there is still a modal one. Could we change that as well as I did in this PR? :)

@sandy081
Copy link
Member

sandy081 commented Jul 23, 2020

@joaomoreno Any reason why you have reverted the change (dialog -> notification) ?

@joaomoreno
Copy link
Member

joaomoreno commented Jul 23, 2020

Please do not bundle these two things together. Product updates are certainly very different from extension updates.

Any reason why you have reverted the change (dialog -> notification) ?

Yeah, because @bpasero complained, and he's correct.

joaomoreno
joaomoreno requested changes Jul 23, 2020
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not combine these two areas. Do not merge this for the product update.

@nrayburn-tech nrayburn-tech mentioned this pull request Jul 27, 2020
Merged
@sandy081
Copy link
Member

sandy081 commented Jul 28, 2020

Closing this based on above comment and also it is not addressing any issue

@sandy081 sandy081 closed this Jul 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joaomoreno joaomoreno joaomoreno requested changes

@sandy081 sandy081 Awaiting requested review from sandy081

Assignees

@sandy081 sandy081

Labels

None yet

Projects

None yet

Milestone

July 2020

Development

Successfully merging this pull request may close these issues.

5 participants

@mathiask88 @msftclas @sandy081 @joaomoreno @kieferrm