Don't fail when resolving config variables without a folderUri.#97203
Merged
weinand merged 2 commits intomicrosoft:masterfrom Nov 18, 2020
Merged
Don't fail when resolving config variables without a folderUri.#97203weinand merged 2 commits intomicrosoft:masterfrom
folderUri.#97203weinand merged 2 commits intomicrosoft:masterfrom
Conversation
bzarco
force-pushed
the
launch-multi-root-args
branch
from
0546931 to
f6f56f1
Compare
Config variables cannot define a workspace folder, but resolution was using `getFolderUri` and failing when undefined, even though `getConfigurationValue` implementations have logic to handle it. This PR changes the logic to simply forward folderUri to `getConfigurationValue`, which can be undefined.
bzarco
force-pushed
the
launch-multi-root-args
branch
from
f6f56f1 to
bed300c
Compare
Member
|
@weinand snow-plow alarm |
Contributor
|
@bzarco thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config variables cannot define a workspace folder, but resolution was using
getFolderUriand failing when undefined, even thoughgetConfigurationValueimplementations have logic to handle it. This PR changes the logic to simply forward folderUri togetConfigurationValue, which can be undefined.This PR fixes #97202