Don't focus editor when un-expanded comment is hidden#97101
Merged
rebornix merged 1 commit intomicrosoft:masterfrom Oct 9, 2020
Merged
Don't focus editor when un-expanded comment is hidden#97101rebornix merged 1 commit intomicrosoft:masterfrom
rebornix merged 1 commit intomicrosoft:masterfrom
Conversation
rebornix
added
bug
Member
|
Thank you for your help! Good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #97100, where the terminal is defocused when comments are changed, which can be caused by terminal commands.
The problem was that when a comment was hidden, it would focus the editor, in order to not have the hidden inline reply editor still focused in the back. But if you hide a comment that is not already expanded, it will still focus the editor, which steals focus from whatever else you had focused.
We don't need to focus the editor if the comment is not expanded.
Tested this by making sure the terminal stays focused even if comments are updated/removed. Also made sure if you open a comment, then type in the reply box, then hide the comment by any means, it would focus the editor and not allow typing in the hidden reply box.