Skip to content

Offer to show git command output on failure#95354

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
diminutivesloop:show-git-command-output
Nov 5, 2020
Merged

Offer to show git command output on failure#95354
joaomoreno merged 1 commit intomicrosoft:masterfrom
diminutivesloop:show-git-command-output

Conversation

@diminutivesloop
Copy link
Contributor

This PR fixes #94711

Adds an option to the git command error dialog to show the entire output from stderr in a readonly file. This is especially useful when a command fails due to a git hook as it lets the user see the reason for the failure without having to wade through unrelated output from the git extension.

To test:

  1. Clone commit-hook-demo.
  2. Install npm dependencies for commit-hook-demo.
  3. Edit hello.js to introduce syntax error.
  4. Attempt to commit changes via the “Git: Commit” command.
  5. When the failure dialog appears click "Show Command Output”.

@msftclas
Copy link

msftclas commented Apr 15, 2020

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno added the git GIT issues label Apr 17, 2020
@diminutivesloop
Copy link
Contributor Author

Hey is there anything else I need to do before this PR can be merged?

@joaomoreno
Copy link
Member

Did some minor refactorings. Overall, the idea was great, thanks!

@joaomoreno joaomoreno added this to the November 2020 milestone Nov 5, 2020
@joaomoreno joaomoreno merged commit ec471da into microsoft:master Nov 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

git GIT issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git: Offer to show the entire git commit output, when it fails

3 participants