Skip to content

Reveal file in OS should work for special files like settings.json wi…#95193

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
usernamehw:revealInOs
Apr 15, 2020
Merged

Reveal file in OS should work for special files like settings.json wi…#95193
isidorn merged 1 commit intomicrosoft:masterfrom
usernamehw:revealInOs

Conversation

@usernamehw
Copy link
Copy Markdown
Contributor

Fixes #95118

@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented Apr 15, 2020

This is just by luck that it works, because luckily fspath will match to a correct location.
However I do not mind merging this in. Thank you for your contribution!

@isidorn isidorn merged commit 7ef215a into microsoft:master Apr 15, 2020
@isidorn isidorn added this to the April 2020 milestone Apr 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reveal in Explorer doesn't work for specific vscode files like settings.json or keybindings.json?

4 participants