Skip to content

handle windows paths beginning with \\?\#95147

Merged
Tyriar merged 2 commits into
microsoft:masterfrom
connorskees:issue-94961
Apr 14, 2020
Merged

handle windows paths beginning with \\?\#95147
Tyriar merged 2 commits into
microsoft:masterfrom
connorskees:issue-94961

Conversation

@connorskees

Copy link
Copy Markdown
Contributor

This should resolve #94961. It does so by optionally allowing drives to be prefixed by \\?\.

@Tyriar

@msftclas

msftclas commented Apr 13, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@connorskees connorskees changed the title handle windows paths beginning with \\?" handle windows paths beginning with \\?\ Apr 13, 2020
@connorskees

Copy link
Copy Markdown
Contributor Author

I'm having trouble replicating the CI errors locally. yarn run mocha --run src/vs/platform/backup/test/electron-main/backupMainService.test.ts says everything is fine, but in CI it timed out,

1) BackupMainService dedupeFolderWorkspaces should ignore duplicates on Windows and Mac (root workspace):
Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

Should I just retry it?

@Tyriar

Tyriar commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

Seems like a flake, also the ci.yml one can probably be ignored so this looks all good. Thanks for covering the new developments too with terminalValidatedLocalLinkProvider.test.ts 😄

@Tyriar Tyriar added this to the April 2020 milestone Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to alt-click file paths beginning with \\?\ on Windows 10

3 participants