fix uri fragment slugification #94508#94655
Merged
mjbvz merged 1 commit intoApr 9, 2020
Merged
Conversation
mjbvz
reviewed
Apr 8, 2020
Contributor
Author
|
Added an additional check for known markdown file extensions. Now links are slugified if they have a markdown file extensions or do not have an extension at all. |
Collaborator
|
Thanks! This change will be in the next VS code insiders build and is scheduled to go out with VS Code 1.45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, all links to local files had their fragment parts normalized (e.g.
foo.md#Bar bazbecamefoo.md#bar-baz). This allowed links to specific sections of other markdown files (file#Section header), but broke many other links.This PR limits the normalization to paths without a file extension (as per suggestion).
This may, however, have an unfortunate side effect of breaking some markdown links that do have an extension (e.g.
foo.md#Bar bazwon't work, butfoo#Bar bazwill).This PR fixes #94508