Feat: #94285 Options on saving before running tasks#94466
Merged
alexr00 merged 11 commits intomicrosoft:masterfrom Apr 23, 2020
Merged
Feat: #94285 Options on saving before running tasks#94466alexr00 merged 11 commits intomicrosoft:masterfrom
alexr00 merged 11 commits intomicrosoft:masterfrom
Conversation
|
|
cumbreras
commented
Apr 5, 2020
| * | ||
| * @param onCancel will be called if the user closed the notification without picking | ||
| * any of the provided choices. | ||
| * @param severity the severity of the notification. Either `Info`, `Warning` or `Error`. |
Contributor
Author
There was a problem hiding this comment.
Not related directly with the implementation but it was outdated documentation of an interface used to complete the feature, updated it based on the current signature.
Member
|
alexr00
requested changes
Apr 8, 2020
Member
|
Looking good so far, just a few changes! |
ProblemMatcherRegistry just when the execution option has been confirmed.
This reverts commit 8ab8402.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #94285
What:
Based on the problem described on #94285; I've added a new set of configurable options that are under the task configuration. This option is saveBeforeRun:
<always|never|prompt>; defaulting to the first option of always saving before running a task (current behavior).How to test:
Include on
settings.json:"task.saveBeforeRun": "never":Execute a task, with this option selected, the editor will not save the dirty editors and run the selected task.
"task.saveBeforeRun": "prompt":Execute a task, with this option selected, the editor will ask you if you want to either save or not save all editors.
"task.saveBeforeRun": "always":Execute a task, with this option selected, the editor will behave as of now, all dirty editors will be saved and the task will be run.