Skip to content

Added a setting to open cloned repository automatically.#94369

Merged
joaomoreno merged 6 commits intomicrosoft:masterfrom
jpiskiewicz:master
Nov 5, 2020
Merged

Added a setting to open cloned repository automatically.#94369
joaomoreno merged 6 commits intomicrosoft:masterfrom
jpiskiewicz:master

Conversation

@jpiskiewicz
Copy link
Contributor

This PR fixes #93300

@msftclas
Copy link

msftclas commented Apr 3, 2020

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno added the git GIT issues label Apr 3, 2020
@yume-chan
Copy link
Contributor

I think it's better called "git.openAfterClone" or something, current name doesn't express that "you can open the folder".

And it looks like you didn't set your Git credentials correctly (probably wrong email), so GitHub doesn't link your commits to your profile.

@jpiskiewicz
Copy link
Contributor Author

I think it's better called "git.openAfterClone" or something, current name doesn't express that "you can open the folder".

@yume-chan Yes, you are right. I think that current name is not the best. I will work on it.

And it looks like you didn't set your Git credentials correctly (probably wrong email), so GitHub doesn't link your commits to your profile.

Yes I've recently changed my email address. I am working to fix this issue.

@owenthereal
Copy link

Love being able to configure opening directly after git clone, instead of clicking the "Open" button

@jpiskiewicz
Copy link
Contributor Author

Love being able to configure opening directly after git clone, instead of clicking the "Open" button

@jingweno this is excactly what I added. If you choose any other option than "showPrompt" it will open the repo after cloning without asking.

@joaomoreno joaomoreno added this to the November 2020 milestone Nov 5, 2020
@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno merged commit e3ace1f into microsoft:master Nov 5, 2020
@jpiskiewicz
Copy link
Contributor Author

Thanks! 🍻

Glad to help!

@joaomoreno
Copy link
Member

FYI ended up refactoring a bit and changing the setting names slightly. Overall, the PR was in very good shape!

@jpiskiewicz
Copy link
Contributor Author

Thanks! I'm looking forward to my future contributions!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

git GIT issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git: After cloning and no folder is open, add option to open the folder automatically.

5 participants